nfdi4plants / ARCitect

Cross-platform app to create and manage ARCs.
9 stars 6 forks source link

[BUG] studies and assays are not registered in isa.investigation file #104

Closed SabrinaZander closed 4 months ago

SabrinaZander commented 10 months ago

Windows 11 ARCitect v. 0.24

All studies and assays are no longer registered in the isa.investigation file. I don't know when this feature was lost, but it is very critical. I'm trying to figure out when this happened.

Brilator commented 10 months ago

Same on macOS

Brilator commented 10 months ago

Works correctly with v0.0.21.

Brilator commented 10 months ago

Maybe happened here? @Freymaurer

https://github.com/nfdi4plants/ARCitect/commit/9d9f43f5e5cc66a15a5258ec86cc1f13635e08ab

Freymaurer commented 10 months ago

May i ask why it is critical to display studies and assays in the investigation file?

SabrinaZander commented 10 months ago

To my knowledge the isa.investigation.xlsx functions as a registry to the ARC. There you have a summary of each study and assay as well as the metadata containing in them.

If you have many studies and assays it is very hard to have an overview without this registration in the isa.investigation.xlsx

Brilator commented 10 months ago

Ah, I see. This was a design decision on isa xlsx that slipped my attention, right? So all studies and assays contained in an ARC are implicitly "registered" without that being written down.

And the study-assay links are only preserved in the respective isa.study.xlsx`s without duplication to the higher level?

HLWeil commented 10 months ago

We have been talking about whether this whole registration makes sense in the context of the ARC, where studies and assays have their own place and (as you stated, @Brilator) the registration is just a source of duplication.

But afaik, we haven't made any implementations based on these discussions in ARCtrl yet.

Brilator commented 8 months ago

This is still confusing.

The Swate investigation dialog now shows "RegisteredStudyIdentifiers" for old ARCs (pre light version) only, not for newly created ARCs.

JonasLukasczyk commented 4 months ago

I will close this for now as it seems not storing redundant information is the way to go.