search

nfdi4plants / ARCitect

Cross-platform app to create and manage ARCs.
9 stars 6 forks source link

[BUG] odd ISA behavior (with odd ARC) #118

Closed Brilator closed 4 months ago

Brilator commented 8 months ago

Just by chance came across an interesting behavior.

At some point I created a script that reads all ISA xlsx files and dumps them as markdowns with same name and structure into a folder at ARC root.

e.g. ./assays/GCqTOF_targets/isa.assay.xlsx --> _isa-md/assays/GCqTOF_targets/isa.assay.xlsx (see https://git.nfdi4plants.org/brilator/Facultative-CAM-in-Talinum)

In the ARCitect I can now open the assay view from the non-ARC-assay folder _isa-md/assays/GCqTOF_targets/.

Might need to enforce absolute paths for ARC contents.

Freymaurer commented 8 months ago

Paths for the ARC are enforced based of arc root. Only the files in ./assays//isa.assay.xlsx are part of the ARC.

Brilator commented 8 months ago

Give it a spin. You can edit the isa.assay.xlsx files from folders not in ./assays/

Freymaurer commented 8 months ago

Cannot see the file in the treeview in v0.0.26

image

But the Add Assay button is definitely a bug.

Edit: One could even say, not displaying the file is a bug too, even making it editable would be fine, as long as it is not added to the main ARC model.

Brilator commented 8 months ago

Try the ARC linked above :)

Freymaurer commented 8 months ago

Try the ARC linked above :)

I see, i forgot to add the assay folder in my example.

From my understanding, while the assay can be edited with ARCitect. It still is not recognized as part of the ARC. I think this could be an unintended feature. What do you think?

Freymaurer commented 4 months ago

Closed for now, feel free to open again.