[BUG] ARCitect always adds a Unit column

nfdi4plants / ARCitect

Cross-plattform app to create and manage ARCs.

9 stars 6 forks source link

[BUG] ARCitect always adds a Unit column #169

Closed Hannah-Doerpholz closed 3 months ago

Hannah-Doerpholz commented 3 months ago

OS and framework information (please complete the following information):

OS: Ubuntu 22.04.4 LTS
ARCitect-0.0.31

Describe the bug

I added a characteristic column for organism to my table and selected "Term", to put in "Hordeum vulgare" from NCBITaxon
After adding, when I expand the table, there is a Unit column, even though there should be none, only TSR and TANs
while the unit column is empty, it shouldn't be there in the first place

Screenshot from 2024-03-20 11-37-37

Freymaurer commented 3 months ago

Is there a unit column in the xlsx when you write it?

Hannah-Doerpholz commented 3 months ago

Aaah, I didn't check that beforehand. No, there is no additional Unit column where it shouldn't be. I guess it is just the display in Swate that is a bit confusing then. But it looks like it's working correctly.

Freymaurer commented 3 months ago

Due to performance reasons this is the current design, but i habe an issue open on the swate repo.

Hannah-Doerpholz commented 3 months ago

I don't think it's a big deal, especially if users are not that familiar with the ISA format. Maybe then they wouldn't even have noticed.