[BUG] Commit with long file names silently fails - Githubissues

nfdi4plants / ARCitect

Cross-plattform app to create and manage ARCs.

9 stars 6 forks source link

[BUG] Commit with long file names silently fails #183

Closed micwij closed 2 weeks ago

micwij commented 1 month ago

OS and framework information (please complete the following information):

OS: Edition: Windows 11 Enterprise
Version: 23H2
OS build: 22631.3527
Arcitect version: 0.0.31

Describe the bug

Commit with files stored in deeply nested folder seems to work
- (files are genome data downloaded from Phytozome and extracted to runs folder during a workflow run)
When moving to DataHUB Sync it says to commit first
Back at commit all file changes are still listed so commit probably failed
Trying arc sync on ArcCommander shows that file names are too long
When moving whole ARC to higher level in Windows commit and sync work with ARCitect
Would be good to have an error message also in ARCitect for too long file names

eik-dahms commented 3 weeks ago

@JonasLukasczyk @Freymaurer

could this be a solution? Just set the congfig accordingly if on a windows system

https://stackoverflow.com/questions/22575662/filename-too-long-in-git-for-windows#:~:text=18%20Answers&text=Git%20has%20a%20limit%20of,260%20characters%20for%20a%20filename.

Freymaurer commented 2 weeks ago

Will look into this in a few minutes and come back after 🙂

Freymaurer commented 2 weeks ago

Hey! So for now we added the git terminal view to remove silent fails!

The issue with long file names still persists but is visible!

At the moment, we are undecided on how to approach this. Should we apply settings to git for the user or should we just return a sensible error?

I will close this issue and open a new issue, in which this can be discussed!

Freymaurer commented 2 weeks ago

This change will be live with the next release! Thanks to @JonasLukasczyk for adding the new view.