search

nfdi4plants / ARCtrl

Library for management of Annotated Research Contexts (ARCs) using an in-memory representation and runtime-agnostic contract systems.
MIT License
11 stars 8 forks source link

Update EXAMPLE_CreateAssayFile.js #346

Closed xiaoranzhou closed 5 months ago

xiaoranzhou commented 5 months ago

Fix "undefined" in column name by change the property into a function. After the change the column name is correct (Input [Source Name]).

Freymaurer commented 5 months ago

Good catch! I also found some more issues with the docs and will update them!

xiaoranzhou commented 5 months ago

Good catch! I also found some more issues with the docs and will update them!

Thanks 😄 . The docs are generally very helpful, I will give heads-up when I found something.

By the way, I use the ARCtrl to make a SWATE template generation tool by parsing the ENA's checklist. I use webpack to bundle the ARCtrl's javascript code and the tool is purely clientside and hosted on a GitHub page. Now I have two questions:

  1. Do you think it make sense to integrate this tool in ARCitect or Swate? I mean, I can also create a small set of template and put them into the Swate template repo, but the selectable requirements/recommended/optional terms does offer some flexibility for a customized Swate template.
  2. Is it possible to add a URL routes so with a URL the Swate can open the template xlsx file and start annotation directly?
Freymaurer commented 5 months ago

Ah nice! I just checked it out and i might have gotten a bad example but maybe you forgot adding term source ref and term accession number to the CompositeHeader elements (see the empty brackets): image

There is definetly room for such "extensions" we are currently working on a lot of restructuring and more features. But we will discuss when and how we could add interoperability to external tools. Feel free to give some ideas on a generalized approach for this 🙂

xiaoranzhou commented 5 months ago

Thanks a lot for looking at the tool and give the helpful feedback. I indeed forgot to add the Mandatory terms of ERC000020 to the ontology mapping files. The ENA template generation tool parse the ENA checklists and an ontology mapping file when the webpage is opened.