[BUG] Wrong Comment types in RO-Crate export of LabProcess and Publication. - Githubissues

nfdi4plants / ARCtrl

Library for management of Annotated Research Contexts (ARCs) using an in-memory representation and runtime-agnostic contract systems.

MIT License

11 stars 7 forks source link

[BUG] Wrong Comment types in RO-Crate export of LabProcess and Publication. #400

Open floWetzels opened 2 months ago

floWetzels commented 2 months ago

In the RO-Crate export, comments attached to ISA types should either be mapped to

the field comment of type Comment, if the ISA type maps to a schema.org type inheriting from CreativeWork, or
to the field disambiguatingDescription of type Text, if the ISA type maps to a schema.org type not inheriting from CreativeWork.

Two types contradict this convention: Publication and Process.

Publication is mapped to ScholarlyArticle which has a comment field, but the current export uses the encoder to disambiguatingDescription, as does the corresponding context file.
Process is mapped to LabProcess which doesn't have a comment field, but the current export uses the encoder to Comment, contradicting its context file.

HLWeil commented 2 months ago

Good catch!

Could you annotate this issue in the ARCStack project, assign yourself if you're going to work on it and remote the Status: Needs Triage tag?