[Feature Request] RO Crate Datamodel - ISA Profile: Add typed getter/setter APIs for known fields

kMutagene commented 2 months ago

Follow-up for #384 as we decided to have more fine-grained PRs/issues on this.

The ISA profile is implemented as classes, but we still need an ergonomic API to work with them programmatically (e.g. to query properties).

As per previous discussion with @HLWeil, here are some necessary implementation details:

all functionality should be implemented as both instance methods and static methods on the class
all methods should use tupled named arguments
static methods should return a function that calls the instance method of the input.

Example:

type A(...) =
  ...
  member this.Foo(arg1, arg2) = ...
  static member foo (arg1, arg2) =
      fun (a: A) -> a.Foo(arg1, arg2)

kMutagene commented 2 months ago

@HLWeil what about static members that only have one argument?

member this.Foo() = ...
static member foo () =
    fun (a: A) -> a.Foo()

or

member this.Foo() = ...
static member foo (a: A) = a.Foo()

?

HLWeil commented 2 months ago

Apparently we kept it consistent. Not sure though whether in this case consistency wins over special case usability.

kMutagene commented 2 months ago

So this one it is?

member this.Foo() = ...
static member foo () =
    fun (a: A) -> a.Foo()

I hate it tbh and would rather change the existing API, but i think this is something for the backlog as of #419

nfdi4plants / ARCtrl