nfdi4plants / Nfdi4Plants.Fornax

Fornax library and template for nfdi4plants/web-components used as docs framework.
MIT License
2 stars 0 forks source link

[Enhancement] Contribution Guide link in Knowledge Base #14

Closed andreaschrader closed 1 year ago

andreaschrader commented 1 year ago

This issue (https://github.com/nfdi4plants/nfdi4plants.knowledgebase/issues/44) was hanging from work at a Hackathon on the DataPLANT Knowledge Base Contributon Guide and seems to require Fornax. I think this needs to be done here in order to have this on all pages of the Knowledge Base?

As I am not experienced in Fornax, I made a suggestion below but kindly ask you to check my suggestion and to implement it correctly.

The idea was to place the Contribution Guide more prominently.

There could be a link on the left side and next or just above and left of the "Edit this page" link directly showing the way to the contribution guide.

Suggestion:

I think, the following could do this when placed before line 47 in the file mentioned below. This is just derived from the "Edit this page" link chunck in line 47 and following in Nfdi4Plants.Fornax/src/Nfdi4Plants.Fornax/Components.fs

            // Contribution Guide link
            // https://nfdi4plants.org/nfdi4plants.knowledgebase/docs/CONTRIBUTING.html
            div [] [
                a [
                    Target "_blank"
                    Href "https://nfdi4plants.org/nfdi4plants.knowledgebase/docs/CONTRIBUTING.html"; 
                    HtmlProperties.Style [MarginRight "auto"; Display "block"; CSSProperties.Width "130px"]
                ] [!! "✏️ Contribution Guide"]
            ]
Freymaurer commented 1 year ago

Will look into this tomorrow. Should i not answer here tomorrow feel free to contact me on teams or ping me here again 😄

Freymaurer commented 1 year ago

Done! image

Will be updated next Thursday evening