search

nfdi4plants / Swate

Excel Add-In for annotation of experimental data and computational workflows.
https://swate-alpha.nfdi4plants.org
MIT License
31 stars 6 forks source link

[BUG] is_a vs. part_of as basis for term-directed search #150

Closed Brilator closed 3 years ago

Brilator commented 3 years ago

Describe the bug

I'm not sure wether part_of relations should also feed into the "related term directed search" (I think added in https://github.com/nfdi4plants/Swate/commit/b10131b5a9957824f8957227ff8b192434adc62e). This allows people to choose values that are literally parts of rather than instances / subclasses (is_a relation) of the parent term.

To Reproduce

Bad example: "Inlet type" is part_of "source". Picking inlet_type as the info for source doesn't tell me anything...

Screen Shot 2021-07-28 at 16 00 57

Expected behavior

Good example: "Electron ionization" is_a "ionization type". And this is what I want to fill in.

Screen Shot 2021-07-28 at 16 13 23

Brilator commented 3 years ago

Needs input from @nfdi4plants/ontologyteam

Zerskk commented 3 years ago

Is there an example commit,, so that i can test this case?

Freymaurer commented 3 years ago

@Zerskk this is currently done by design from Swate. The database functions that handle relationships do currently not discriminate between is_a and part_of relationships. This was done because, i think it was @omaus, noticed that he was not able to find a "child" term in one of the ontologies.