nfdi4plants / Swate

Excel Add-In for annotation of experimental data and computational workflows.
https://swate-alpha.nfdi4plants.org
MIT License
31 stars 6 forks source link

[Feature Request] Protocol columns #207

Closed HLWeil closed 2 years ago

HLWeil commented 2 years ago

Protocol Type column:

Motivation: https://github.com/nfdi4plants/nfdi4plants_ontology/issues/32

To fill out the protocolType field in the protocol.json, it would be nice to have a Protocol Type column in SWATE. This could be insertable into the table the same way as Input or Output columns. And the Ontology term search feature could be used to insert ontology terms related to the Protocol Type in our ontology.

This might look something like this: image

Protocol REF column:

Currently, the Excel Sheet name is used as the protocol name. The problem is, that the excel sheet names are restricted to 31 characters. To allow for longer protocol names and also to give more control to the user, the Protocol REF column could be introduced in SWATE . This column is already defined in the ISA-Tab standard. It could also be inserted into the table like the input and output columns.

Freymaurer commented 2 years ago

According Part 1 of this issue, we now have featured columns. I decided on this name, because it more or less is "Parameter [protocol type]" made easier accessible for the user. They can be found by clicking on the star symbol, which will open a new subpage in the dropdown.

I chose this design to keep the main dropdown as clean as possible, while also allowing for more future additions like "Protocol Type"

image image

Freymaurer commented 2 years ago

Let me know what you think @HLWeil. I will close this issue in some days and reopen one only for the second part of this issue.

HLWeil commented 2 years ago

Maybe alternatively pack the Protocol type and Protocol REF columns in a protocol columns tab? But in principle I'm fine with that approach too 👍