nfdi4plants / Swate

Excel Add-In for annotation of experimental data and computational workflows.
https://swate-alpha.nfdi4plants.org
MIT License
30 stars 6 forks source link

[Feature Request]: support protocol import #413

Closed Brilator closed 1 week ago

Brilator commented 2 months ago

Contact Details

No response

Is your feature request related to a problem?

The Excel plug-in allowed to import a filled out process / protocol as .json

Describe the solution you would like!

Would help to offer this feature again in swate alpha / ARCitect

Additional context!

No response

Host

Standalone

Host Details

Standalone and ARCitect

Freymaurer commented 2 weeks ago

@Brilator What information should be imported? Full assay? Just a single table?

Freymaurer commented 2 weeks ago

Make it choosable what to import!

Freymaurer commented 1 week ago

Not finished, but here is a preview of the current design:

Image

Freymaurer commented 1 week ago

@Brilator Have a look and tell me if that is the correct direction 🙂

Brilator commented 1 week ago

(Direction) looks very good

Freymaurer commented 1 week ago

"Import type" options are exclusive? Either column headers or column headers + predefined units or column headers + units + values. If so, I would rearrange accordingly.

Yes Options, are exclusive and exactly as you think they are. Will rearrange!

"Metadata" might be confusing. Needs to be clearer what metadata is meant here (it's the top-level ISA metadata right? So study/ assay or template info with person records etc., i.e. not biological / experimental metadata)

Exactly! How should i rename it? Because ISA seems not directly correct, and top-level not very intuitive.

Multiple Template Tables (Table 1, Table 2) would origin from an isa.assay.xlsx / isa.study.xlsx with multiple sheets "Table 1"? I really like the flexible options (import, append, no import)

Yes!

I think "Template" is misleading and should be something like "ISA table"

Template Table 1 is the name i gave the table, so it will be whatever the table was called by the protocol creator.

What's behind the dropdown?

A scrollable table preview of the protocol table:

image

Thinking about it now, i should propably already show correct format and not inverse column and row 😞

Brilator commented 1 week ago

Exactly! How should i rename it? Because ISA seems not directly correct, and top-level not very intuitive.

Tricky. Description / Details / Information / Meta information / Registration / Registry metadata / about the table to be imported.

Maybe more importantly, I'd suggest to move that modal down to bottom and have the box unchecked by default.

A scrollable table preview of the protocol table:

Nice.

Thinking about it now, i should propably already show correct format and not inverse column and row

Yes

Freymaurer commented 1 week ago

Tricky. Description / Details / Information / Meta information / Registration / Registry metadata / about the table to be imported.

Maybe more importantly, I'd suggest to move that modal down to bottom and have the box unchecked by default.

I am now checking which file was imported and add the filetype in front of the Metadata:

image

And currently everything is unchecked by default 😅

Thinking about it now, i should propably already show correct format and not inverse column and row

Yes

Done!

Freymaurer commented 1 week ago

I finally finished the logic. As it is a rather complex logic, feel free to open an issue if it feels off!

Will be live with the next release!