nfdi4plants / Swate

Excel Add-In for annotation of experimental data and computational workflows.
https://swate-alpha.nfdi4plants.org
MIT License
30 stars 6 forks source link

[Bug]: Unit is only displayed in first row #419

Closed SabrinaZander closed 1 week ago

SabrinaZander commented 1 month ago

Contact Details

No response

What happened?

When you add building blocks with a unit the unit is only displayed in the first row. In all other rows the Unit/TSR/TAN building block is empty.

Screenshot 2024-05-13 131210

What did you expect?

Unit information should be added in all rows.

Host

ARCitect

Host Details

ARCitect v.0.0.31

Swate version

v1.0.0-beta.03

Freymaurer commented 1 month ago

What was your workflow?

Added building block with unit. Then added rows? Or were there already 3 rows and you added a building block afterwards?

SabrinaZander commented 1 month ago

I first added building blocks with unit and then added rows. But I tried also the other way around and the problem is still the same.

ZimmerD commented 3 weeks ago

Can confirm this behaviour on my machine, windows 11, 23H2

Freymaurer commented 2 weeks ago

I am a bit conflicted about this issue, as the behavior exactly mimics the behavior of adding a building block with a term:

Image

Which will add the term exactly in row 1. I am a big fan of consistency and wanted to ask:

  1. Should i also fill the full collumn for terms?
  2. Should i only fill units for the full column?

@ZimmerD @SabrinaZander

SabrinaZander commented 1 week ago

In my opinion, only units should be filled for the entire column. Because I think it is more likely that the terms will be different in different rows ( see example). If you want to have the same term in the whole column you can easiely use the fill column button. With units it is not that easy. Only when you do this at step 1 and you don't have any numbers in the colums yet. Otherwise you will have the same number with a unit in all columns.

Hope you can understand what I mean :-)

image

Freymaurer commented 1 week ago

I had some discussions about this issue and the following will be implemented:

The Add Building block logic will always fill all available rows with the body term! I think this is the best solution and fits user expectations best.

Freymaurer commented 1 week ago

Done! This will be part of the next release!