nfdi4plants / Swate

Excel Add-In for annotation of experimental data and computational workflows.
https://swate-alpha.nfdi4plants.org
MIT License
31 stars 6 forks source link

[Feature Request]: DataMap header terms #483

Closed Freymaurer closed 1 month ago

Freymaurer commented 1 month ago

Contact Details

No response

Is your feature request related to a problem?

The new datamap feature contains three term like headers:

image

Currently these are added without identifier, therefore no parent-child search triggers and it simply looks like mistake

Describe the solution you would like!

These terms should also be referenced using identifier, similiar to featured column Protocol Type

Which terms should we use for this? This will also support parent-child search for these columns.

Maybe you can tell me which terms would fit best @StellaEggels .

Additional context!

https://github.com/nfdi4plants/ARC-specification/blob/main/ISA-XLSX.md#datamap-table-sheets

Host

Applies to All

Host Details

.

StellaEggels commented 1 month ago

For unit you can for sure use the unit ontology (UO:0000000), for Object type I think data type (NCIT:C42645) will fit. Explication isn't clear to me, maybe Data item (SIO:000069) or data file description (NGBO:6000418), but I am not sure if that is what is asked here.

Freymaurer commented 1 month ago

@HLWeil can you verify?

HLWeil commented 1 month ago

"Unit" and "Data Type" proposed by @StellaEggels fit well. Not sure if we should costrain the range of Explication though. It's kind of a wildcard for any term.

Freymaurer commented 1 month ago

Thanks, will start implementing then!

HLWeil commented 1 month ago

On another note, @Freymaurer :

  1. Is it possible to remove the "Parameter" part of the headers?
  2. Is it possible to remove the units?
Freymaurer commented 1 month ago

Is it possible to remove the "Parameter" part of the headers?

Yes we would need to implement these as FeaturedColumns in ARCtrl (to be factually correct) or i can hardcode something in Swate

Is it possible to remove the units?

This is just a ui thing. it is greyed out, they do not have units. Maybe this can be improved in the future. This behavior is consistent across all Swate tables.

Freymaurer commented 1 month ago

Just talked to @HLWeil about this and mabye its a good idea to create a new term explication without any child terms. Therefore we would have an ontologized header term without narrowing down the child search. What do you think @StellaEggels ?

StellaEggels commented 1 month ago

Sounds good, if you can provide a definition I will add it to DPBO.

Freymaurer commented 1 month ago

@HLWeil ?

HLWeil commented 1 month ago

I would go from here:

Class: Explanation

and adjust to:

Class: Explication

StellaEggels commented 1 month ago

added (DPBO:0000111)

Freymaurer commented 1 month ago

Thanks everyone for contributing! @StellaEggels @HLWeil