nfdi4plants / Swate

Excel Add-In for annotation of experimental data and computational workflows.
https://swate-alpha.nfdi4plants.org
MIT License
31 stars 6 forks source link

[BUG] Displayed IRIs in Swate still incorrect #537

Open Hannah-Doerpholz opened 1 day ago

Hannah-Doerpholz commented 1 day ago

Describe the bug When I search for terms (e.g. extraction buffer, a DPBO term), and I want to click the link I still get an error message. When I check the URL, I see that there are still the purl.obolibrary.org links used, instead of the purl.org links. The same is true for other ontologies such as EFO for example, that don't use obolibrary purls.

To Reproduce Steps to reproduce the behavior:

  1. Open Swate: https://swate-alpha.nfdi4plants.org/
  2. Open the right-hand menu and go to Ontology term search
  3. Type in either extraction buffer (DPBO:0000050) or family relationship (EFO:0004424)
  4. Click on the term link

Expected behavior For extraction buffer I expected to be lead to the URL http://purl.org/nfdi4plants/ontology/dpbo/DPBO_0000050 For family relationship I expected to be lead to the URL http://www.ebi.ac.uk/efo/EFO_0004424

Related issues/PRs This was previously discussion in issue nfdi4plants/ARCtrl#368 The corresponding PR from that time is nfdi4plants/ARCtrl#381

OS and framework information (please complete the following information):

Additional context Currently (17.10.2024) the internet archive is still under attack which hosts the "expected" purls (purl.org), so ATM none of the expected DPBO links should work until that is resolved.

HLWeil commented 22 hours ago

Hey @Hannah-Doerpholz, thanks for bringing this up.

I checked ARCtrl and this should be fixed.

#r "nuget: ARCtrl, 2.1.0-alpha.4"

open ARCtrl

let efoOA = OntologyAnnotation(tan = "EFO:0004424")

efoOA.TermAccessionOntobeeUrl

let dpboOA = OntologyAnnotation(tan = "DPBO:0000050")

dpboOA.TermAccessionOntobeeUrl

returns

val it: string = "https://bioregistry.io/EFO:0004424"
val it: string = "http://purl.org/nfdi4plants/ontology/dpbo/DPBO_0000050"

First glance this looks like it's not updated in Swate yet @Freymaurer?

Freymaurer commented 19 hours ago

Have to check, will transfer to Swate for now