Open floWetzels opened 1 year ago
I think we can close this, having created our own profile in https://github.com/nfdi4plants/isa-ro-crate-profile? @floWetzels
This is no longer relevant for us, so I think you're right. But I guess this is still something to keep in mind to talk to some of the ISA people to? Not sure...
ISA json-context files from the isa-api have the following semantical problems for the conversion to RO-Crate
Mapping leading to problems with RO-Crate
Contexts overall do not fit to
RO-Crate
conventions, since all studies and assays (subfolders in an ARC) should besdo:Dataset
:see RO-Crate specification.
Mapping leading to illegal relationships
isa:Assay
mapped tosdo:MedicalTest
,isa:measurementType
mapped tosdo:variableMeasured
, but the latter is not part ofsdo:MedicalTest
, even though such a relationship exists in the datamodel.isa:characteristicCategories
mapped tosdo:measuredProperty
, but the latter not part ofsdo:MedicalTest
.isa:Study
mapped tosdo:MedicalStudy
,isa:studyDesignDescriptors
mapped tosdo:trialDesign
, but the latter is not part ofsdo:MedicalStudy
.isa:affiliations
of isa:Person
mapped tosdo:affiliation
ofsdo:Person
, but types don't fit (Text vs Organization). Where doesisa:Organization
come from? Not part of the specification.Mapping of non-existent fields
Assay context
maps identifier, name, description, but they are not properties ofisa:Assay
.Mapping which doesn't fit semantically
isa:Sample
tosdo:Product
isa:Protocol
tosdo:HowTo
isa:Comment
tosdo:Comment
(they describe different things!).isa:material
mapped tosdo:participant
.Thus, I suggest to write ARC/RO-Crate specific context files manually.