nfdi4plants / arc-validate-package-registry

A repository of validation packages for ARCs
https://avpr.nfdi4plants.org
MIT License
1 stars 2 forks source link

Add PRIDE validation package #16

Closed omaus closed 6 months ago

omaus commented 7 months ago

This PR

kMutagene commented 7 months ago

@omaus note that publishing and merging into this repo are two separate things.

We can absolutely merge this when more metadata is added.

kMutagene commented 7 months ago

@omaus sorry to nudge you so much but can you please add author and tag metadata so we can merge this? Should not take long.

omaus commented 7 months ago

@omaus sorry to nudge you so much but can you please add author and tag metadata so we can merge this? Should not take long.

Yeah thx, pls check if it is done right (I'm esp. unsure about the publish: true). 👍🏻

kMutagene commented 7 months ago

Lgtm, but pls do not set publish - this is intended for full immutable release, and iirc we want to adapt arcexpect api before that

kMutagene commented 7 months ago

But commiting to this repo makes the package available as prerease already

omaus commented 7 months ago

Lgtm, but pls do not set publish - this is intended for full immutable release, and iirc we want to adapt arcexpect api before that

Done.

kMutagene commented 7 months ago

thanks @omaus, heads up that i will push some changes to your branch to test some ci capabilities

omaus commented 7 months ago

@kMutagene

Unit test says that version is wrong. I don't see why that should be the case. The file's name is "pride@1.0.0.fsx", YAML tags:

MajorVersion: 1
MinorVersion: 0
PatchVersion: 0

???

kMutagene commented 6 months ago

???

Those are the default values the metadata class gets initialized with if the frontmatter is invalid !!! Note that also the StagingDirectory.FileContent.All files have valid metadata test fails. The issue is that your file gets checked out with LF on windows instead of CRLF. Not sure why but i really do not care, ill just replace line endings on parsing frontmatter.

kMutagene commented 6 months ago

Also, name in ontology tags should be Name, which is my bad.