search

nfdi4plants / arc-validate-package-registry

A repository of validation packages for ARCs
https://avpr.nfdi4plants.org
MIT License
1 stars 2 forks source link

Move submission to a cli based 2-step process #57

Open HLWeil opened 1 month ago

HLWeil commented 1 month ago

Just discovered that the invenio validation package does not behave correctly #56. Currently looking for fixes, but would like some extra security in shape of unit tests which check the correct working of the validation package. Is there any place for this currently?

kMutagene commented 3 weeks ago

I see pros and cons for this.

On one hand, validation packages such as invenio are so integral to out tool stack that maybe we should include further testing in this repo's CI pipelines. On the other hand, this repo is a registry, validation packages are just provided 'as-is'. In this framework, the author of a package has to make sure that it works, not the author of the registry. Imagine something like npm or nuget being responsible to run further testing if the packages "work" (whatever that means).

So i think at the end of the day we want to transition from a one-step submission process - that is, people submitting single script files to this repo - to a two-step submission process, where validation packages are their own repos with full testing pipelines and whatnot. submission should then be handled via a cli tool in a predefined format. This is basically what all the examples for package registries i mentioned do. But this is a lot of extra work and i do not think something we want to tackle this year.

So the intermediate solution i would suggest here would be adding tests for invenio specifically, and leave testing to authors on all other submissions.