nfdi4plants / arc-validate

Home of all the tools and libraries to create and run validation of ARCs
https://nfdi4plants.github.io/arc-validate/
MIT License
3 stars 2 forks source link

Refactor fillTokens function from ValidationPackage POC into ARCExpect #71

Closed kMutagene closed 5 months ago

kMutagene commented 6 months ago

Not sure about the naming though. Reminder @omaus , this is the section:

https://github.com/nfdi4plants/arc-validate/blob/bf1995584a06eb0a0353ac4a35a038d45dd6e48e/playgrounds/qcPackage_prototypes/invenio_prototype_v0.1.0.fsx#L83-L93

omaus commented 6 months ago

Wouldn't this fail? This function needs ARCTokenization functionality (okay so far) and ARCExpect functionality (as of now, since ARCGraph is still part of ARCExpect). But ARCExpect itself also depends on ARCTokenization, so both libraries would depend on each other.

kMutagene commented 6 months ago

Yeah i meant arcexpect sorry