search

nfdi4plants / arc-validate

Home of all the tools and libraries to create and run validation of ARCs
https://nfdi4plants.github.io/arc-validate/
MIT License
3 stars 2 forks source link

`Validate.IParamCollection.forAll` #88

Open omaus opened 4 months ago

omaus commented 4 months ago

This PR

kMutagene commented 4 months ago

@omaus how do you intend to proceed on this? for reference, the new API design guidelines are here: https://nfdi4plants.github.io/arc-validate/ARCExpect/design.html.

Do you intend to start with a fresh PR or adapt the code in this one?

omaus commented 4 months ago

@omaus how do you intend to proceed on this? for reference, the new API design guidelines are here: https://nfdi4plants.github.io/arc-validate/ARCExpect/design.html.

Do you intend to start with a fresh PR or adapt the code in this one?

This is just about renaming, isn't it? So it should be much easier to just rename the functions instead of writing everything anew.

omaus commented 3 months ago

I updated the function's name to fit the naming design and also changed it in a way that the first param that does not satisfy the predicate is shown instead of a part of the whole collection.

omaus commented 3 months ago

and also changed it in a way that the first param that does not satisfy the predicate is shown instead of a part of the whole collection.

Btw. is this okay or would you prefer to show all predicate failing items?

omaus commented 3 months ago

and also changed it in a way that the first param that does not satisfy the predicate is shown instead of a part of the whole collection.

Btw. is this okay or would you prefer to show all predicate failing items?

Okay, tweaked it so that it goes throw the whole collection.