search

nfdi4plants / arc-validate

Home of all the tools and libraries to create and run validation of ARCs
https://nfdi4plants.github.io/arc-validate/
MIT License
3 stars 2 forks source link

Baseline validation #93

Closed LibraChris closed 2 months ago

LibraChris commented 2 months ago

Add baseline Validation for ARCs in case no specific validation package is referenced

LibraChris commented 2 months ago

@kMutagene Check this out please! I am happy do change anything you say needs a rework.

LibraChris commented 2 months ago

Hey @kMutagene, please review the changes made and let me know if they are ok. I noticed that the way I referenced a file in the tests seem to fail in linux but seems to work in the windows tests. If you let me know what I need to change to fix this I will do it asap.

kMutagene commented 2 months ago

@LibraChris please double check that path that fails in ci. Something like that failing on linux but passing on windows often means that there is a lowercase/uppercase mistake in the path.

LibraChris commented 2 months ago

@LibraChris please double check that path that fails in ci. Something like that failing on linux but passing on windows often means that there is a lowercase/uppercase mistake in the path.

You are 100% correct. But strange that it worked on Mac.

LibraChris commented 2 months ago

Hey @kMutagene , I addressed the changes you requested. Let me know if it looks good.

LibraChris commented 2 months ago

@kMutagene How about now?