search

nfdi4plants / dataplan

DataPLAN is a Data Management Plan (DMP) generator developed by DataPLANT
https://plan.nfdi4plants.org
GNU General Public License v3.0
3 stars 4 forks source link

Checkbox "Yes! I will use DataPLANT." has no effect #10

Closed Brilator closed 2 years ago

Brilator commented 2 years ago

Unfortunately, checking the box

Yes! I will use DataPLANT.

did not update my DMP accordingly. None of the #if$_DATAPLANT statements made it into my DMP, meaning I have to add them manually now :(

Brilator commented 2 years ago

Also the "Do you need visualization in the project?" option just resets my previous selections.

xiaoranzhou commented 2 years ago

Are you using Safari on a Mac? For me the Chrome and Firefox works both fine. I only tested it on the safari of my ipad. If you can provide your browser, OS version and saved JSON file, that will be helpful to debug. I can not debug if I can not recreate your bugs.

xiaoranzhou commented 2 years ago

Unfortunately, checking the box

Yes! I will use DataPLANT.

did not update my DMP accordingly. None of the #if$_DATAPLANT statements made it into my DMP, meaning I have to add them manually now :(

What do you mean by adding them manually?

Brilator commented 2 years ago

I filled out the dataplan (right panel), downloaded (copied) the text to a word document, since I cannot edit the text blocks in the browser. Now, I've checked the index.html for every time #if$_DATAPLANT was used in the DFG template and add these blocks to my DMP doc...

Brilator commented 2 years ago

Are you using Safari on a Mac? For me the Chrome and Firefox works both fine. I only tested it on the safari of my ipad. If you can provide your browser, OS version and saved JSON file, that will be helpful to debug. I can not debug if I can not recreate your bugs.

Yes. Works in Firefox. Cannot confirm that it works on iPad (did not on mine, iOS 15.6). Does not work in macOS 12.5 / Safari 15.6.

Maybe add a warning to the top.

xiaoranzhou commented 2 years ago

Are you using Safari on a Mac? For me the Chrome and Firefox works both fine. I only tested it on the safari of my ipad. If you can provide your browser, OS version and saved JSON file, that will be helpful to debug. I can not debug if I can not recreate your bugs.

Yes. Works in Firefox. Cannot confirm that it works on iPad (did not on mine, iOS 15.6). Does not work in macOS 12.5 / Safari 15.6.

Maybe add a warning to the top.

I think it should work. Are you using some plugins which will modify your webpage? You can test it in Incognito page. The function I use was all promised to function in the new Safari.... I can try to debug them in a VM but it take some time.

xiaoranzhou commented 2 years ago

I filled out the dataplan (right panel), downloaded (copied) the text to a word document, since I cannot edit the text blocks in the browser. Now, I've checked the index.html for every time #if$_DATAPLANT was used in the DFG template and add these blocks to my DMP doc...

You can actually try the "user defined template" in "Template" menu. There you could edit every thing just like before.

xiaoranzhou commented 2 years ago

@Brilator Hey Dominik, I recreated the bug and fixed it. I can push it now if it is OK for you. Otherwise you can also try it here: link

Brilator commented 2 years ago

@Brilator Hey Dominik, I recreated the bug and fixed it. I can push it now if it is OK for you. Otherwise you can also try it here: link

Yes, works in Safari now. (the link btw doesn't).