search

nfdi4plants / isa-ro-crate-profile

MIT License
4 stars 0 forks source link

Some updates for Investigation, Study and Assay profiles #17

Closed floWetzels closed 2 months ago

floWetzels commented 3 months ago

This PR removes several properties of Assay from the profile that seem to be copied from Study, as they do not correspond to any ISA properties. An exception is the creator/performer of an assay. I kept it in there, since it is also part of an ARC Assay. See Issue https://github.com/nfdi4plants/isa-ro-crate-profile/issues/5 for details.

Furthermore, some Study and Investigation properties were changed from MUST to SHOULD.

@stuzart Could you have a look at this? I think we had some longer discussions about the MUST properties of Investigation, Study and Assay at the Hackathon, but in this form they fit with the ARC tools that export an RO-Crate.

I will probably add further changes for other issues (https://github.com/nfdi4plants/isa-ro-crate-profile/issues/4, https://github.com/nfdi4plants/isa-ro-crate-profile/issues/7, https://github.com/nfdi4plants/isa-ro-crate-profile/issues/9) regarding Investigation, Study and Assay to this PR as well.

floWetzels commented 2 months ago

The filename property of the ISA types has now been integrated as url for all three types. (https://github.com/nfdi4plants/isa-ro-crate-profile/issues/7 and https://github.com/nfdi4plants/isa-ro-crate-profile/issues/9)

floWetzels commented 2 months ago

The dates properties of the ISA types have also been adapted, see https://github.com/nfdi4plants/isa-ro-crate-profile/issues/4.