reorder some profile rows

nfdi4plants / isa-ro-crate-profile

MIT License

4 stars 0 forks source link

reorder some profile rows #23

Closed kMutagene closed 4 days ago

kMutagene commented 1 month ago

Hey there, i'm currently implementing this profile and thought that the order of rows should be consistent across I/S/A so it is easier to read and see properties that exist across multiple types.

If the original order was there for a reason,. feel free to ignore this.

HLWeil commented 1 month ago

Are Assay and Study the only two types with differing key order?

Aside from that, I don't mind the change. @floWetzels

HLWeil commented 6 days ago

@floWetzels

floWetzels commented 4 days ago

The initial ordering indeed had some purpose, but you are right that it is flawed, @kMutagene. I tried to order the properties by MUST-SHOULD-COULD. I think most of your changes/reorderings don't contradict that, but some do. Could you slightly modify it in that way?

kMutagene commented 4 days ago

@floWetzels i now applied the following ordering rules:

Group rows by MUST > SHOULD > COULD
inside those groups, sort Property alphabetically (A > Z)

I applied that rule to all tables in the profile.

floWetzels commented 4 days ago

Sounds good, thanks!