search

nfdi4plants / isa-ro-crate-profile

MIT License
4 stars 0 forks source link

DateModified #4

Open HLWeil opened 4 months ago

HLWeil commented 4 months ago

DateModified is a field used in Study and Investigation profiles, but they don't have an corresponding field in ISA(json). Is this by design?

floWetzels commented 2 months ago

I think it is by design to allow for more detailed date specification than in pure ISA (the terms do not match 100% anyway). But I think there is a mistake. As you pointed out, DateModified is the additional term, while the other two (DateCreated and DatePublished) are intended to describe the ISA terms (submissionDate and publicReleaseDate). However, the requirements are off: DateModified should obviously be COULD and the other two SHOULD, which is not the case. For now, I will only change the requirements and keep all three properties. But I am open to remove the DateModified property if this is requested.

floWetzels commented 1 month ago

I adapted the date properties in PR https://github.com/nfdi4plants/isa-ro-crate-profile/pull/17. Should we consider this issue fixed or do we need further modifications, @HLWeil @stuzart?