search

nfdi4plants / isa-ro-crate-profile

MIT License
4 stars 0 forks source link

Person ORCID field? #8

Closed Freymaurer closed 2 months ago

Freymaurer commented 5 months ago

Currently we have no field in Person (and here) to represent ORCID.

I suggest using identifier, but there might be more appropriate fields.

floWetzels commented 4 months ago

I think @HLWeil's suggestion in https://github.com/nfdi4plants/isa-ro-crate-profile/issues/16 could also be applied here.

stuzart commented 3 months ago

for the workflow ro crate we use identifier for the ORCID, e.g.

{
      "@id": "https://orcid.org/0000-0001-8875-7304",
      "@type": "Person",
      "name": "Thomas Roetzer-Pejrimovsky",
      "identifier": "https://orcid.org/0000-0001-8875-7304"
    }
floWetzels commented 3 months ago

Yes, that's a good option. It fits with Lukas' suggestion on PubMedIDs or DOIs. Since identifier allows for PropertyValue objects, we can use them to specify that it is an identifier of type ORCID:

{
  "@id": "https://orcid.org/0000-0001-8875-7304",
  "@type": "Person",
  "name": "Thomas Roetzer-Pejrimovsky",
  "identifier": {
    "propertyID": "ORCID",
    "value": "0000-0001-8875-7304"
  }
}

To me, it doesn't really matter which option w choose.

floWetzels commented 2 months ago

Fixed by PR https://github.com/nfdi4plants/isa-ro-crate-profile/pull/19