search

nfdi4plants / nfdi4plants_ontology

An intermediate ontology for plants used by DataPLANT to fill the ontology gap
MIT License
7 stars 10 forks source link

Duplicate "Biological replicate" #11

Closed Freymaurer closed 2 years ago

Freymaurer commented 3 years ago

The following Term: "Biological replicate" was added to the nfdi4pso ontology, even though the term already exists in the ms ontology. The ms term is even referenced in the comment.

[Term] id: NFDI4PSO:0000042 name: Biological replicate def: "Indicates the biological replication during experiment design (e.g. 'rep1', 'rep2')" comment: “Similar to http://purl.obolibrary.org/obo/MS_1001809"

I propose we delete the duplicate term, except i am missing something here.

@Brilator commit

Brilator commented 3 years ago

Def of MS_1001809: "the run was generated from another individual or sample" sounded too specific to me, esp. due to "run" and being associated to MS. More importantly, I guess we shouldn't delete anything from the broker ontology (just now) for persistence. But we'll have to learn how to properly develop the ontology in the future with TA1.