nfdi4plants / nfdi4plants_ontology

An intermediate ontology for plants used by DataPLANT to fill the ontology gap
MIT License
7 stars 10 forks source link

nfdi4pso should not contain a number? #33

Closed Freymaurer closed 1 year ago

Freymaurer commented 2 years ago

While working on Swate i was presented with a link, showing defined parsing options for IDSPACE and LOCALID in term accessions. The below text comes from the original issue and shows the code example and explains subparts of it. tl;dr according to the official docs IDSPACE MUST NOT contain a number, but nfdi4pso contains a number. What should we do here?


From the code shown here s@((**[A-Za-z_]***):(d+))@http://purl.obolibrary.org/obo/$1_$2@:

This does not look good for our nfdi4pso.

@muehlhaus maybe this should be a discussion point on future meetings. For now i will keep numbers in the swate internal parsing.

Originally posted by @Freymaurer in https://github.com/nfdi4plants/Swate/issues/210#issuecomment-1173739558

Brilator commented 2 years ago

I don't think this is a big issue. Apart from swate templates, our "ontology" hasn't been used much (and not referred to anywhere externally, I assume).

So we can just replace it with a proper IDSPACE in the obo and all template files.

kdumschott commented 1 year ago

The ontology namespace has been changed to dpbo