nfdi4plants / nfdi4plants_ontology

An intermediate ontology for plants used by DataPLANT to fill the ontology gap
MIT License
7 stars 8 forks source link

Swate selecting values from xref ++ is_a / has_participant #38

Closed Brilator closed 1 year ago

Brilator commented 1 year ago

Hey, I've spotted a small "xref" issue with terms and "is_a" instances selectable from within SWATE (term-directed search).

For example: The term DPBO:0000040 (used to be NFDI4PSO:0000040) has some child terms required for "next generation sequencing instrument model" to comply with e.g. GEO requirements. However, using the term-directed search yields a lot of sequencing techniques (DNA-seq, ChIP-Seq, etc.) rather than instruments.

[Term]
id: DPBO:0000040
name: next generation sequencing instrument model
def: "Model name or number of next generation sequencing instrument" []
xref: EFO:0003739

The term is xref'ed to "EFO:0003739" (sequencer) https://www.ebi.ac.uk/ols/ontologies/efo/terms?short_form=EFO_0003739 and if I understand the panel on the right correctly, those techniques come from the "has_participant" relationship?

Brilator commented 1 year ago

@Freymaurer @Zerskk Linking you here since this might be an issue how Swate / SwateDB handles xref and is_a?

Freymaurer commented 1 year ago

I tried looking for child terms in swate and get exactly these instrument models?

image

Can you give me the use case where this behaves unexpected?

Brilator commented 1 year ago

Sorry, my bad. the behavior happened on the obsolete term NFDI4PSO:0000040. So it relates somewhat to nfdi4plants/Swate#236

Screen Shot 2022-11-17 at 16 18 07
Freymaurer commented 1 year ago

In my opinion we should close this issue then and just work on not showing obsolete nfdi4pso/dpbo terms in the search results 👍 If you are okay with this @Brilator

Brilator commented 1 year ago

true