search

nfhipona / AutoCompleteTextField

TextField with smart suggestion for email inputs
http://nfhipona.github.io/AutoCompleteTextField/
MIT License
65 stars 13 forks source link

Swiftlint #7

Closed lfarah closed 8 years ago

lfarah commented 8 years ago

I'd be cool to add Swiftlint and it's very easy to install. I already fixed all the Swiftlint warnings for AutoCompleteTextField, so It's all about installing and then I can make a pull request 😄

nfhipona commented 8 years ago

@lfarah Swiftlint is only to verify the mistakes of the coder when initializing objects right? I don't think we need this, but let me have some of your thoughts of why we are needing this. Thanks!

lfarah commented 8 years ago

Swiftlint helps in following the Swift Guidelines. I fixed about 20 erros in AutoCompleteTextField, most of them being in CGRectMake(), that has to be CGRect(x:,y:,:width:,height:), }else{ that had to be } else {, CGRectZero that had to be CGRect.zero. I always add Swiftlint to all my projects and it's soooo useful. I really love it!

nfhipona commented 8 years ago

Ah yes. Those part was actually an Obj-C type initialization. I have issues with compiler before when it was xcode 6.0 it was having too many sourcekit errors. I will keep this in mind thanks! I think let's decide this one later whether really need it or not. I'll be updating this tomorrow night around this time when I'm in my workstation. :)

nfhipona commented 8 years ago

@lfarah okay updated. All are conforming to swift syntax and there should be no more ObjC syntax traces. 👍