search

nficano / python-lambda

A toolkit for developing and deploying serverless Python code in AWS Lambda.
ISC License
1.5k stars 229 forks source link

fix lambda deployment #714

Closed rashadmoarref closed 2 years ago

rashadmoarref commented 2 years ago

This PR fixes issue https://github.com/nficano/python-lambda/issues/711 by adding a waiter on function_updated.

bokats commented 2 years ago

@rashadmoarref Any idea when this will be merged. I am seeing the same issue.

rashadmoarref commented 2 years ago

@bokats I opened the PR, but would leave it for the repo maintainer to review and merge. @nficano, would you be able to review and merge this PR? I'm internally working with the fork I created and this PR resolves the deployment issue. Please let me know if you need additional information :)

gdvalderrama commented 2 years ago

Just tried these changes to get it to work. Only needed the waiter, I guess the click version change is just a plus.

UPDATE: I'm actually using this PR from my dependencies meanwhile, in my requirements file: git+https://github.com/nficano/python-lambda.git@refs/pull/714/head

Lowess commented 2 years ago

Can we please get this ticket merged as it seems like everyone need to shift to this branch to get the project working ?

rashadmoarref commented 2 years ago

@nficano Could we move ahead with merging this PR? It will save a lot of time from other people coming up with the same solution, such as https://github.com/nficano/python-lambda/pull/716