Support multiple search results

nfischer / framily-tree

:beers: An interactive family tree for Theta Chi fraternity

https://nfischer.github.io/framily-tree/

MIT License

7 stars 13 forks source link

Support multiple search results #11

Closed austinberke closed 4 months ago

austinberke commented 6 years ago

Problem:

Typing in a query that matches multiple brothers will only return one result based on first match of nodes.find()

Proposed solution:

Populate list of all matches within nodes using nodes.filter()
Show indicator of multiple matches near search box
Add Next button or hit Enter to cycle through all results

nfischer commented 6 years ago

I wonder, is this necessary? For example, if I search for nick and get the wrong one, I'll usually type in a last name. Do you have a scenario in mind for where my approach wouldn't be as natural a response?

austinberke commented 6 years ago

It's not super high priority, but my issue with it is a matter of defined behavior: it seems nodes.find() will return an arbitrary match which doesn't seem like the best practice for a search function.

nfischer commented 6 years ago

Fair point. Maybe after we change the internals to return multiple search results, we could score and order the results. Currently, sometimes the returned result isn't the best one (e.g., "jose" points to "Joseph Dominguez).