nfischer / framily-tree

:beers: An interactive family tree for Theta Chi fraternity
https://nfischer.github.io/framily-tree/
MIT License
7 stars 11 forks source link

test: clearer error message for inconsistent names #33

Closed nfischer closed 1 year ago

nfischer commented 1 year ago

This adds some logic to try to detect a few common cases where names are inconsistent.

codecov-commenter commented 1 year ago

Codecov Report

Base: 59.21% // Head: 57.69% // Decreases project coverage by -1.51% :warning:

Coverage data is based on head (1828834) compared to base (4e1fc3b). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #33 +/- ## ========================================== - Coverage 59.21% 57.69% -1.52% ========================================== Files 2 2 Lines 152 156 +4 ========================================== Hits 90 90 - Misses 62 66 +4 ``` | [Impacted Files](https://codecov.io/gh/nfischer/framily-tree/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nate+Fischer) | Coverage Δ | | |---|---|---| | [main.js](https://codecov.io/gh/nfischer/framily-tree/pull/33/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nate+Fischer#diff-bWFpbi5qcw==) | `56.86% <0.00%> (-1.53%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nate+Fischer). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nate+Fischer)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.