nfischer / framily-tree

:beers: An interactive family tree for Theta Chi fraternity
https://nfischer.github.io/framily-tree/
MIT License
7 stars 11 forks source link

refactor: remove dead code for error handling #44

Closed nfischer closed 4 months ago

nfischer commented 4 months ago

This removes some dead code which does some error handling. These error cases should be obsolete now that we have tests which parse the full brothers.js file to ensure we can parse successfully.

This also adds /* istanbul ignore next */ statements for some code which is not testable: either because it is for error cases which are not expected, or because it is for browser-only code (tests run in NodeJS, so they won't ever be able to cover browser-only code).

Test: npm test Test: npm start (verify that this runs OK in the browser)

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.72%. Comparing base (8a4331e) to head (24a135a).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #44 +/- ## =========================================== + Coverage 60.13% 72.72% +12.59% =========================================== Files 2 2 Lines 148 121 -27 =========================================== - Hits 89 88 -1 + Misses 59 33 -26 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.