nfischer / framily-tree

:beers: An interactive family tree for Theta Chi fraternity
https://nfischer.github.io/framily-tree/
MIT License
7 stars 11 forks source link

Handle misformatted data better #6

Closed nfischer closed 6 years ago

nfischer commented 6 years ago

Data might be in an unexpected format (e.g., someone might lack both a "big bro" and a "family started" due to data entry mistakes). This is something we can easily handle in the code.

We could either add these guys to a separate family (named "UNKNOWN") or output warnings/errors in the console.

nfischer commented 6 years ago

Another issue: we should have better error output/tolerance when there's a typo for "big brother name." This case can also happen if we inconsistently use nicknames (e.g., "Alexander" vs. "Alex").

Right now, this is fatal and with a cryptic error message ("Cannot read property 'id' of undefined"). We should consider clearer error output, and explicitly decide whether or not this should be a fatal error.