search

nfl / react-gpt

A React display ad component using Google Publisher Tag
MIT License
145 stars 84 forks source link

Fix slotOnload to use the correct on event name #75

Closed gabelew closed 6 years ago

gabelew commented 6 years ago

The event name returned is slotOnload, so the funcName generated in _onEvent in createManager.js is actually onSlotOnload and needs to be corrected.

codecov[bot] commented 6 years ago

Codecov Report

Merging #75 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files           8        8           
  Lines         580      580           
=======================================
  Hits          545      545           
  Misses         35       35
Impacted Files Coverage Δ
src/Bling.js 90.95% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08a9b1c...47fcc0e. Read the comment docs.

potench commented 6 years ago

I don't think we have tests for any of these GPT pass-through events. Should consider introducing one here. Gonna accept this for now, but if you have a minute, can you PR a couple test cases to validate these pass-through events?