nfl / react-gpt

A React display ad component using Google Publisher Tag
MIT License
145 stars 84 forks source link

Working another way of resetting a pageview for roadblocks or competi… #95

Open rdlsf-omg opened 5 years ago

rdlsf-omg commented 5 years ago

…tive exclusions

Taking in consideration the best practices found in: https://support.google.com/admanager/answer/183281?hl=en

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 5 years ago

Codecov Report

Merging #95 into master will decrease coverage by 0.18%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   93.96%   93.78%   -0.19%     
==========================================
  Files           8        8              
  Lines         580      579       -1     
==========================================
- Hits          545      543       -2     
- Misses         35       36       +1
Impacted Files Coverage Δ
src/createManager.js 91.92% <100%> (-0.49%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60f6ce0...d4e0c24. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #95 into master will decrease coverage by 0.18%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   93.96%   93.78%   -0.19%     
==========================================
  Files           8        8              
  Lines         580      579       -1     
==========================================
- Hits          545      543       -2     
- Misses         35       36       +1
Impacted Files Coverage Δ
src/createManager.js 91.92% <100%> (-0.49%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60f6ce0...d4e0c24. Read the comment docs.