search

nfl / react-helmet

A document head manager for React
MIT License
17.34k stars 660 forks source link

Add warning to docs about async rendering incompatibility #614

Open richardscarrott opened 4 years ago

richardscarrott commented 4 years ago

I've put the warning in the server rendering section but worried people will miss it so perhaps it should go at the top of the README?

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 4 years ago

Codecov Report

Merging #614 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #614   +/-   ##
=======================================
  Coverage   96.90%   96.90%           
=======================================
  Files           3        3           
  Lines         291      291           
=======================================
  Hits          282      282           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b57ddb...16ad678. Read the comment docs.