search

nfl / react-helmet

A document head manager for React
MIT License
17.34k stars 660 forks source link

Support non-string exports responsive-loader #616

Open dsheiko opened 4 years ago

dsheiko commented 4 years ago

Module https://github.com/dazuaz/responsive-loader exports images as an object like { src: "", srcSet: ", ..}. Helmet expects a string and therefore crushes as: TypeError: tag[primaryAttributeKey].toLowerCase is not a function

CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov[bot] commented 4 years ago

Codecov Report

Merging #616 into master will decrease coverage by 0.63%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #616      +/-   ##
==========================================
- Coverage   96.90%   96.27%   -0.64%     
==========================================
  Files           3        3              
  Lines         291      295       +4     
==========================================
+ Hits          282      284       +2     
- Misses          9       11       +2
Impacted Files Coverage Δ
src/HelmetUtils.js 96.05% <50.00%> (-0.83%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b57ddb...4ca9371. Read the comment docs.