nflaig / semantic-release-helm

semantic-release plugin to publish Helm charts
MIT License
13 stars 11 forks source link

feat: allow skipping of registry login command in verifyConditions #22

Closed sjoukedv closed 1 year ago

sjoukedv commented 1 year ago

I need to push to artifactory which does not support the helm registry login command, but does work with helm push. With this new parameter I can disable the check.

Signed-off-by: Sjouke de Vries info@sdvservices.nl

sjoukedv commented 1 year ago

why is verifyRegistryLogin called at all if skipRegistryLogin is true?

My bad, I am doing this besides my regular work. I have fixed the issue accordingly

nflaig commented 1 year ago

My bad, I am doing this besides my regular work

Same and this code base sucks, hate vanilla JS, I just forked the original package to get some features in I wanted but now seems like people start using my package instead of original since I am still "maintaining" it.

nflaig commented 1 year ago

I also don't use this anymore so I don't have a good setup to quickly test changes... and since there are 0 tests and no linting / other static type checks changing anything is really error prone. Need to be careful not to break things.