nflath / c-eldoc

eldoc-mode plugin for C source code
33 stars 15 forks source link

Updated for compatibility with Emacs 26 and 27. #16

Closed pierre-rouleau closed 3 years ago

pierre-rouleau commented 3 years ago

Hello Nathaniel,

I made changes so the code will no longer produce the warnings except for the cache functions. For those the byte-compiler reports the "not known to be defined" warning at the end of the file. There would be several ways to solve this warning: 1- add fbound checks in the code 2- remove the local definition of the cache.el code and update the dependency of c-eldoc.el to make it depend on cache.el and then just leave the (require 'cache) in c-eldoc.el 3- leave the cache.el code inside c-eldoc and remove the conditional and the require 'cache)

I would prefer option 2 , but that's your decision.

Also, I'd like to go further by changing the defer into customization using a defgroup for c-eldoc and defcustoms. But that would be after you have agreed to it.

Thanks

/Pierre

pierre-rouleau commented 3 years ago

Something else I would like to do is convert the code to use lexical-binding. Do you have any objection or know of thongs to watch for?

nflath commented 3 years ago

No objections to that