nflverse / nfl_data_py

Python code for working with NFL play by play data.
MIT License
252 stars 48 forks source link

Fix DataFrame indexing - import_ids() #71

Open brendanillies opened 11 months ago

brendanillies commented 11 months ago

First time doing this so bear with me!

Function import_ids() was using an incorrect DataFrame indexing method - namely specifying set vs. list. Added type conversion as well as a default case of returned columns ret_columns to remove multiple lines of redefining the df variable. Also added passing test cases around the change and added test case caching to be ignored.