search

nflverse / nfl_data_py

Python code for working with NFL play by play data.
MIT License
252 stars 48 forks source link

[BUG] import_schedule shows wrong week for rest #86

Open darkhark opened 5 months ago

darkhark commented 5 months ago

Is there an existing issue for this?

Have you installed the latest development version of the package(s) in question?

If this is a data issue, have you tried clearing your nflverse cache?

I am not using an nflverse R package (nflreadr, nflfastR) to access this data.

What version of the package do you have?

0.3.1

Describe the bug

If the home_rest and away_rest columns are meant to represent each team's bye weeks, they appear to default to 7. This is for week 1: image The rest value changes depending on the week for the same teams too.

Reprex

import nfl_data_py as nfl
nfl.import_schedules([2023])[['away_team', 'home_team', 'away_rest', 'home_rest']]

Expected Behavior

The values in rest week show the same bye week for the same team no matter the week.

nflverse_sitrep

NA

Screenshots

Added to description

Additional context

Not urgent, but I planned on imputing values using the bye week.

smenon02 commented 5 months ago

is there anyone working on this? If not, I can take it up

darkhark commented 5 months ago

is there anyone working on this? If not, I can take it up

You're the first reply. Feel free to go for it!