search

nflverse / nflfastR

A Set of Functions to Efficiently Scrape NFL Play by Play Data
https://www.nflfastr.com/
Other
414 stars 50 forks source link

increment fixed drive on lost fumbles with play type pass, run or punt #419

Closed mrcaseb closed 1 year ago

mrcaseb commented 1 year ago

fixes #418

We already incremented fixed drive on lost fumbles (with later recovery in the same play) of punts and on interceptions.

We didn't do it for run plays nor did we for pass plays with completed passes.

The missing run plays were the cause of #418. But there were about 20 other plays from 1999:2022 affected by not doing it on completed passes.

I changed it to increment on punt, pass and run (for now). It fixes all relevant plays and doesn't change anything else. So this should be good to go.

github-actions[bot] commented 1 year ago

🚀 Deployed on https://64eefd28c244e558afb8857f--thirsty-brown-d38ddf.netlify.app

github-actions[bot] commented 1 year ago

🚀 Deployed on https://64eef451ace62c4c6356c28f--thirsty-brown-d38ddf.netlify.app

guga31bb commented 1 year ago

lgtm- ty!