nflverse / nflfastR

A Set of Functions to Efficiently Scrape NFL Play by Play Data
https://www.nflfastr.com/
Other
414 stars 50 forks source link

[BUG] incorrect `end_clock_time` for the 2023 play by play data #428

Closed mistakia closed 6 months ago

mistakia commented 1 year ago

From the released csv

game_id: 2023_01_ARI_WAS
play_id: 39
end_clock_time: 2023-09-10T17:02:47.537Z

end_clock_time appears to be endClockTime from v1 api which is not the intended behavior. The correct value would be 15:00

{
  "clockTime": "15:00",
  "down": 0,
  "driveNetYards": 11,
  "drivePlayCount": 4,
  "driveSequenceNumber": 1,
  "driveTimeOfPossession": "1:44",
  "endClockTime": "2023-09-10T17:02:47.537Z",
   ...
  "playDescription": "M.Prater kicks 65 yards from ARI 35 to end zone, Touchback.",
  "playDescriptionWithJerseyNumbers": "5-M.Prater kicks 65 yards from ARI 35 to end zone, Touchback.",
  "playId": 39,
  "playType": "KICK_OFF",
   ...
}

For the time being, an alternative solution would be to use the endGameClock from ngs

{
  "gameId": 2023091007,
  "playId": 39,
   ...
  "playType": "play_type_kickoff",
  "possessionTeam": "ARI",
  "possessionTeamId": "3800",
  "quarter": 1,
  "season": 2023,
  "seasonType": "REG",
  "visitorScore": 0,
  "week": 1,
  "yardlineNumber": 35,
  "yardlineSide": "ARI",
  "yardsToGo": 0,
  "endGameClock": "15:00",
  "isRedzonePlay": false,
  "startGameClock": "15:00"
}
mrcaseb commented 6 months ago

Since we can no longer use NGS and there is no way to fix this in our raw PBP data, I will close this as won't fix.