nflverse / nflfastR

A Set of Functions to Efficiently Scrape NFL Play by Play Data
https://www.nflfastr.com/
Other
414 stars 50 forks source link

For game_id == "2023_13_ARI_PIT", the weather delays botched up the calculation of fixed_drive and fixed_drive_result #447

Closed JoeMarino2021 closed 6 months ago

JoeMarino2021 commented 9 months ago

Is there an existing issue for this?

Have you installed the latest development version of the package(s) in question?

If this is a data issue, have you tried clearing your nflverse cache?

I have cleared my nflverse cache and the issue persists.

What version of the package do you have?

4.5.1.9012

Describe the bug

If Week 13 2023 data is loaded into a variable called dfPbP2020, one may execute the following in RStudio.

View(dfPbP2020 %>% filter(game_id == "2023_13_ARI_PIT") %>% select(desc, yardline_100, fixed_drive, fixed_drive_result))

If one scrolls down to fixed_drive 14, it is apparent that fixed_drive 14 is a combination of a touchdown drive by Arizona and a missed field goal drive by the Steelers.

If this could be looked at and a decision could be made about whether to address this or not, it would be appreciated. Since it is rare enough to have weather delays, maybe you guys would rather ignore this issue. If you choose to ignore it, I'd like to know so I'll pay special attention to games I know were weather delayed.

Thanks!

Reprex

See Description above.

Expected Behavior

I hope that weather delays in the future will not cause fixed_drive and fixed_drive_results errors.

nflverse_sitrep

── System Info ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• R version 4.3.1 (2023-06-16 ucrt) • Running under: Windows 10 x64 (build 19045)
── Package Status ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   package  installed  cran        dev   behind
1   nfl4th      1.0.4 1.0.4 1.0.4.9001      dev
2 nflfastR 4.5.1.9012 4.6.0 4.6.0.9000 cran;dev
3 nflplotR 1.1.0.9006 1.2.0 1.2.0.9003 cran;dev
4 nflreadr   1.4.0.03 1.4.0   1.4.0.09      dev
5 nflseedR      1.2.0 1.2.0      1.2.0         
6 nflverse      1.0.3 1.0.3      1.0.3         
── Package Options ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• No options set for above packages
── Package Dependencies ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• askpass     (1.1)     • janitor      (2.2.0)   • stringr     (1.5.0)    
• backports   (1.4.1)   • jsonlite     (1.8.7)   • sys         (3.4.2)    
• cachem      (1.0.8)   • labeling     (0.4.3)   • tibble      (3.2.1)    
• cli         (3.6.1)   • lifecycle    (1.0.3)   • tidyr       (1.3.0)    
• colorspace  (2.1-0)   • listenv      (0.9.0)   • tidyselect  (1.2.0)    
• cpp11       (0.4.6)   • lubridate    (1.9.2)   • timechange  (0.2.0)    
• crayon      (1.5.2)   • magick       (2.7.5)   • utf8        (1.2.3)    
• curl        (5.0.2)   • magrittr     (2.0.3)   • vctrs       (0.6.3)    
• data.table  (1.14.8)  • memoise      (2.0.1)   • viridisLite (0.4.2)    
• digest      (0.6.33)  • mime         (0.12)    • withr       (2.5.0)    
• dplyr       (1.1.2)   • munsell      (0.5.0)   • xgboost     (1.7.5.1)  
• fansi       (1.0.4)   • openssl      (2.1.0)   • codetools   (0.2-19)   
• farver      (2.1.1)   • parallelly   (1.36.0)  • compiler    (4.3.1)    
• fastmap     (1.1.1)   • pillar       (1.9.0)   • graphics    (4.3.1)    
• fastrmodels (1.0.2)   • pkgconfig    (2.0.3)   • grDevices   (4.3.1)    
• furrr       (0.3.1)   • progressr    (0.14.0)  • grid        (4.3.1)    
• future      (1.33.0)  • proto        (1.0.0)   • lattice     (0.21-8)   
• generics    (0.1.3)   • purrr        (1.0.2)   • MASS        (7.3-60)   
• ggpath      (1.0.1)   • R6           (2.5.1)   • Matrix      (1.5-4.1)  
• ggplot2     (3.4.3)   • rappdirs     (0.3.3)   • methods     (4.3.1)    
• globals     (0.16.2)  • RColorBrewer (1.1-3)   • mgcv        (1.8-42)   
• glue        (1.6.2)   • Rcpp         (1.0.11)  • nlme        (3.1-162)  
• gsubfn      (0.7)     • rlang        (1.1.1)   • parallel    (4.3.1)    
• gtable      (0.3.4)   • rstudioapi   (0.15.0)  • splines     (4.3.1)    
• hms         (1.1.3)   • scales       (1.2.1)   • stats       (4.3.1)    
• httr        (1.4.7)   • snakecase    (0.11.1)  • tools       (4.3.1)    
• isoband     (0.2.7)   • stringi      (1.7.12)  • utils       (4.3.1)    
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

Screenshots

N/A

Additional context

N/A

mrcaseb commented 9 months ago

Oh no, I knew the weather delay would come after us. Thanks for reporting the issue @JoeMarino2021