Release nflfastR 4.6.1

[mrcaseb]

CRAN forces us to submit a new version because they found this file https://github.com/nflverse/nflfastR/blob/master/tests/testthat/setup.R

It was intended to set data.table to two cores on CRAN machines but it never worked and we skip tests on cran.

So this release is as easy as delete above file and submit. CRAN submissions are closed until January 9th, so we have to wait.

If Uwe Ligges ever reads this: it's not our fault. You forced package developers with (reverse) dependencies on openMP to find a way around the multi threading problem and ultimately make everyone skip tests on CRAN. Bravo. Helps nobody.

Prepare for release:

• [ ] git pull
• [x] Check current CRAN check results
• [x] Polish NEWS
• [x] urlchecker::url_check()
• [x] devtools::build_readme()
• [x] devtools::check(remote = TRUE, manual = TRUE)
• [x] devtools::check_win_devel()
• [x] revdepcheck::revdep_check(num_workers = 4)
• [x] Update cran-comments.md
• [ ] git push
• [x] devtools::check_mac_release()
• [x] rhub::check_for_cran(email = "mrcaseb@gmail.com", show_status = FALSE)
• [x] pkgdown::check_pkgdown()
• [x] usethis::use_tidy_thanks()

Submit to CRAN:

• [ ] usethis::use_version('patch')
• [x] devtools::submit_cran()
• [x] Approve email

Wait for CRAN...

• [ ] Accepted :tada:
• [ ] usethis::use_github_release()
• [ ] usethis::use_dev_version(push = TRUE)

[mrcaseb]

If we ever want to return to running tests on CRAN, we can try setting another environment variable as described here https://stat.ethz.ch/pipermail/r-package-devel/2023q4/009969.html