search

nflverse / nflfastR

A Set of Functions to Efficiently Scrape NFL Play by Play Data
https://www.nflfastr.com/
Other
414 stars 50 forks source link

automatically recognize ID version #458

Closed mrcaseb closed 6 months ago

mrcaseb commented 6 months ago

We are going to run into the problem that some older seasons could switch player IDs if we have to reload the raw pbp data for some reason, e.g. #456.

This messes up the current approach where we assumed that 2023+ uses Elias IDs and older seasons remain with gsis.

This PR allows nflfastR to identify the player ID as gsis or elias and decode the ID regardless of version.

github-actions[bot] commented 6 months ago

🚀 Deployed on https://65ddb9122e5823b95cd8a007--thirsty-brown-d38ddf.netlify.app