scrambles for older years

nflverse / nflfastR

A Set of Functions to Efficiently Scrape NFL Play by Play Data

https://www.nflfastr.com/

Other

414 stars 50 forks source link

scrambles for older years #468

Closed guga31bb closed 2 months ago

guga31bb commented 3 months ago

Still a work in progress. The older years of data are a mess in the NFL pbp

github-actions[bot] commented 3 months ago

🚀 Deployed on https://667be8d27ae555df297e1297--thirsty-brown-d38ddf.netlify.app

guga31bb commented 3 months ago

@mrcaseb I think this is ready except for the test failing because it changes the output and no longer matches expected output (eg scramble, rush, pass etc change on some plays)

mrcaseb commented 3 months ago

I can update test expectation but will be out of town until Sunday

mrcaseb commented 3 months ago

Seems like MacOS isn't happy with the new expectation. I will review later.

Also I introduced some new "global variable" warnings that could be fixed in this PR as well

guga31bb commented 2 months ago

Tests still failing?

tanho63 commented 2 months ago

rounding error, looks like. I would try adding this tolerance param to expect_equal and set it to ~ 0.00001 or so

guga31bb commented 2 months ago

Still fails even with a pretty lenient tolerance. I am confused. It's like it's ignoring the tolerance param.