nflverse / nflfastR

A Set of Functions to Efficiently Scrape NFL Play by Play Data
https://www.nflfastr.com/
Other
414 stars 50 forks source link

[BUG] 2023 play-by-play is missing the end_yard_line data #469

Closed Useight closed 2 months ago

Useight commented 3 months ago

Is there an existing issue for this?

Have you installed the latest development version of the package(s) in question?

If this is a data issue, have you tried clearing your nflverse cache?

I have cleared my nflverse cache and the issue persists.

What version of the package do you have?

NA

Describe the bug

In the .csv file for the 2023 play-by-play data, the column labeled "end_yard_line" is blank for every row.

Reprex

NA.

Expected Behavior

The data should be there, just as it is for previous seasons.

nflverse_sitrep

NA.

Screenshots

No response

Additional context

No response

mrcaseb commented 2 months ago

This information is gone in our data source so we can't do much about it. In theory it is possible to compute the end yardline with yardline and yards_gained but it's not likely that we invest time to add it in nflfastR

Useight commented 2 months ago

I thought that might be the case. I had the same idea for calculating the end yardline, but it was actually more complicated than simply adding the yards_gained to the yardline. For example, a play on the ten yard line that gains ten yards does not have an end yardline at all because it was a touchdown. Or a kickoff that goes out of bounds automatically has an end yardline of 40. Lots of edge cases like that.

I did write a C# program that calculates it all, so I have the end yardlines for the 2023 plays. You can have it if you want, but I can't guarantee 100% accuracy.