search

nflverse / nflfastR

A Set of Functions to Efficiently Scrape NFL Play by Play Data
https://www.nflfastr.com/
Other
414 stars 50 forks source link

Add new function `calculate_stats()` #470

Open mrcaseb opened 2 months ago

mrcaseb commented 2 months ago

This implements #445

mrcaseb commented 2 months ago

It turned out that some stats are hard to compute using the playstats because some stats require information of other players, e.g. receiving_air_yards.

The remaining stats probably need to be computed using pbp. I didn't start this yet

github-actions[bot] commented 2 months ago

🚀 Deployed on https://66ad00eb8362b37a2152e106--thirsty-brown-d38ddf.netlify.app

jacobakaye commented 2 months ago

What does this function do?

mrcaseb commented 2 months ago

What does this function do?

See here https://github.com/nflverse/nflfastR/blob/f59b2e672a3bb80b7ee570a63db0d070d0c46acb/NEWS.md?plain=1#L15

jacobakaye commented 2 months ago

I installed the development version, and the old function 'calculate_player_stats' still worked while I got the error with the new function.

calculate_stats(pbp) Error in calculate_stats(pbp) : could not find function "calculate_stats"

tanho63 commented 2 months ago

I installed the development version, and the old function 'calculate_player_stats' still worked while I got the error with the new function.

calculate_stats(pbp) Error in calculate_stats(pbp) : could not find function "calculate_stats"

Use

pak::pkg_install("nflverse/nflfastR#470")

to install the PR branch version. the development version refers to what is merged to main